From 5b1d3672b96429e48c08e7cf17ec07144e0eb0ed Mon Sep 17 00:00:00 2001
From: Luigi Pinca <luigipinca@gmail.com>
Date: Fri, 1 Jun 2012 22:05:59 +0200
Subject: [PATCH] fixed a URL encoding issue

---
 package.json             | 4 ++--
 public/static/js/room.js | 2 +-
 routes/site.js           | 4 ++--
 routes/user.js           | 1 -
 views/index.jade         | 3 ++-
 views/room.jade          | 3 ++-
 views/user.jade          | 4 ++--
 7 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/package.json b/package.json
index 5f28688..8c8328b 100644
--- a/package.json
+++ b/package.json
@@ -17,5 +17,5 @@
   "engines": {
     "node": "0.6.x"
   },
-  "version": "0.3.1"
-}
+  "version": "0.3.1-1"
+}
\ No newline at end of file
diff --git a/public/static/js/room.js b/public/static/js/room.js
index 185bf62..d623266 100644
--- a/public/static/js/room.js
+++ b/public/static/js/room.js
@@ -238,7 +238,7 @@
             var guesstime = $('<span class="guess-time"></span>');
             li.append(pvt, username, points, roundrank, roundpointsel, guesstime);
             if (user.registered) {
-                var href = 'href="/user/'+encodeURI(username.html())+'"';
+                var href = 'href="/user/'+encodeURIComponent(user.nickname)+'"';
                 pvt.after('<a class="registered" target="_blank" '+href+'></a>');
             }
             DOM.users.append(li);
diff --git a/routes/site.js b/routes/site.js
index 5e09ea1..0dce102 100644
--- a/routes/site.js
+++ b/routes/site.js
@@ -30,7 +30,7 @@ exports.use = function(options) {
 
 exports.index = function(req, res) {
     if (req.session.user) {
-        res.local('loggedin', req.session.user.replace(/&/g, "&amp;"));
+        res.local('loggedin', req.session.user);
     }
     res.render("index", {rooms:rooms});
 };
@@ -68,7 +68,7 @@ exports.artworks = function(req, res) {
 exports.room = function(req, res) {
     if (rooms.indexOf(req.params.room) !== -1) {
         if (req.session.user) {
-            res.local('loggedin', req.session.user.replace(/&/g, "&amp;"));
+            res.local('loggedin', req.session.user);
         }
         res.render("room", {roomname:req.params.room,rooms:rooms});
     }
diff --git a/routes/user.js b/routes/user.js
index 77178b8..b7237bb 100644
--- a/routes/user.js
+++ b/routes/user.js
@@ -192,7 +192,6 @@ exports.profile = function(req, res) {
     db.exists(key, function(err, data) {
         if (data === 1) {
             db.hgetall(key, function(e, obj) {
-                obj.username = obj.username.replace(/&/g, '&amp;');
                 obj.bestguesstime = (obj.bestguesstime/1000).toFixed(1);
                 obj.worstguesstime = (obj.worstguesstime/1000).toFixed(1);
                 if (obj.guessed !== '0') {
diff --git a/views/index.jade b/views/index.jade
index 1a214b6..2ad25d3 100644
--- a/views/index.jade
+++ b/views/index.jade
@@ -18,7 +18,8 @@ html
                         if (typeof(loggedin) !== "undefined")
                             li
                                 p.navbar-text Logged in as 
-                                    a#loggedin(href="/user/#{loggedin}",target="_blank") #{loggedin}
+                                    a#loggedin(href="/user/#{encodeURIComponent(loggedin)}",
+                                        target="_blank") #{loggedin.replace(/&/g, '&amp;')}
                             li
                                 a(href="/logout") Logout
                         else
diff --git a/views/room.jade b/views/room.jade
index 0d8af23..75a46ad 100644
--- a/views/room.jade
+++ b/views/room.jade
@@ -27,7 +27,8 @@ html
                         if (typeof(loggedin) !== "undefined")
                             li
                                 p.navbar-text Logged in as 
-                                    a#loggedin(href="/user/#{loggedin}",target="_blank") #{loggedin}
+                                    a#loggedin(href="/user/#{encodeURIComponent(loggedin)}",
+                                        target="_blank") #{loggedin.replace(/&/g, '&amp;')}
                             li
                                 a(href="/logout") Logout
                         else
diff --git a/views/user.jade b/views/user.jade
index c4c91a5..208d0ae 100644
--- a/views/user.jade
+++ b/views/user.jade
@@ -1,7 +1,7 @@
 doctype html
 html
     include header
-        title binb :: #{username} info
+        title binb :: #{username.replace(/&/g, '&amp;')} info
     body
         include uv.jade
         .navbar.navbar-fixed-top
@@ -13,7 +13,7 @@ html
             section
                 .row
                     .span7.offset1
-                        .profile #{username}
+                        .profile #{username.replace(/&/g, '&amp;')}
                             .img
                         div member since #{joindate}
             section
-- 
2.54.0