From: Luigi Pinca <luigipinca@gmail.com>
Date: Tue, 5 Apr 2016 16:46:12 +0000 (+0200)
Subject: do not extend `String.prototype` with non-standard methods
X-Git-Url: https://git.saalbach.dev/?a=commitdiff_plain;h=9f0eb1c01c567d9a36cfaff22d4ca39fd79623f9;p=binbsis50.git

do not extend `String.prototype` with non-standard methods
---

diff --git a/public/js/app.js b/public/js/app.js
index b5156e8..c5c307c 100644
--- a/public/js/app.js
+++ b/public/js/app.js
@@ -96,10 +96,6 @@
     , 'Yes, you guessed the title. Who is the artist?'
   ];
 
-  String.prototype.encodeEntities = function() {
-    return this.replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;');
-  };
-
   var addCassetteBackdrop = function() {
     var html = [
       '<div id="touch-backdrop">'
@@ -540,6 +536,10 @@
     $users.empty();
   };
 
+  var encodeEntities = function(str) {
+    return str.replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;');
+  };
+
   var gameOver = function(podium) {
     var html = [
       '<div class="modal-header">'
@@ -1077,7 +1077,7 @@
         , splits = text.split(urlregex);
 
       for (var i = 0; i < splits.length; i++) {
-        var escapedsplit = splits[i].encodeEntities();
+        var escapedsplit = encodeEntities(splits[i]);
 
         if (urlregex.test(splits[i])) {
           html += '<a target="_blank" href="' + escapedsplit + '">' +
@@ -1091,7 +1091,7 @@
       return html;
     }
 
-    return text.encodeEntities();
+    return encodeEntities(text);
   };
 
   // A new player has joined the game